Sea-Studio/MC_Report
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: duplicate res.json crash + missing try/catch in bans POST

Browse Source
This commit is contained in:
canglan
2026-07-18 01:45:00 +08:00
parent 5cb17228a8
commit 12721d09ee
1 changed files with 19 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
backend/routes/bans.js
View File

@@ -27,24 +27,28 @@ router.get('/min-duration', authenticate, async (req, res) => {
}); });
router.post('/', authenticate, requireRole('owner'), async (req, res) => { router.post('/', authenticate, requireRole('owner'), async (req, res) => {
const { player_name, player_uid, reason, type, duration, ticket_id, expires_at, source } = req.body; try {
if (!player_name) return res.status(400).json({ error: '玩家名为必填' }); const { player_name, player_uid, reason, type, duration, ticket_id, expires_at, source } = req.body;
if (!player_name) return res.status(400).json({ error: '玩家名为必填' });
const durDays = parseDuration(duration); const durDays = parseDuration(duration);
const prev = await getRow('SELECT * FROM bans WHERE (player_name = ? OR player_uid = ?) AND type = ? AND status = ? ORDER BY created_at DESC LIMIT 1', const prev = await getRow('SELECT * FROM bans WHERE (player_name = ? OR player_uid = ?) AND type = ? AND status = ? ORDER BY created_at DESC LIMIT 1',
[player_name, player_uid||'', type||'ban', 'active']); [player_name, player_uid||'', type||'ban', 'active']);
if (prev && durDays > 0 && parseDuration(prev.duration) > durDays) { if (prev && durDays > 0 && parseDuration(prev.duration) > durDays) {
return res.status(400).json({ error: `该玩家已有${parseDuration(prev.duration)}天处罚记录，新处罚时长不可少于上次（需 ≥ ${parseDuration(prev.duration)}天）` }); return res.status(400).json({ error: `该玩家已有${parseDuration(prev.duration)}天处罚记录，新处罚时长不可少于上次（需 ≥ ${parseDuration(prev.duration)}天）` });
} }
const r = await query('INSERT INTO bans(player_name, player_uid, source, reason, type, duration, ticket_id, created_by, expires_at) VALUES (?,?,?,?,?,?,?,?,?)', const r = await query('INSERT INTO bans(player_name, player_uid, source, reason, type, duration, ticket_id, created_by, expires_at) VALUES (?,?,?,?,?,?,?,?,?)',
[player_name, player_uid||'', source||'', reason||'', type||'ban', duration||'', ticket_id||null, req.user.id, expires_at||null]); [player_name, player_uid||'', source||'', reason||'', type||'ban', duration||'', ticket_id||null, req.user.id, expires_at||null]);
if (ticket_id) { if (ticket_id) {
await query("INSERT INTO responses(ticket_id, user_id, content, is_staff) VALUES (?,?,?,1)", await query("INSERT INTO responses(ticket_id, user_id, content, is_staff) VALUES (?,?,?,1)",
[ticket_id, req.user.id, `【处罚记录】${type==='ban'?'封禁':type==='mute'?'禁言':type==='warn'?'警告':'其他'}: ${player_name}${duration?' 时长:'+duration:''}${reason?' 原因:'+reason:''}`]); [ticket_id, req.user.id, `【处罚记录】${type==='ban'?'封禁':type==='mute'?'禁言':type==='warn'?'警告':'其他'}: ${player_name}${duration?' 时长:'+duration:''}${reason?' 原因:'+reason:''}`]);
}
res.status(201).json({ id: r.insertId });
} catch (err) {
console.error('[bans]', err);
res.status(500).json({ error: '添加失败: ' + err.message });
} }
res.status(201).json({ id: r.insertId });
res.status(201).json({ id: r.insertId });
}); });
router.put('/:id', authenticate, requireRole('owner'), async (req, res) => { router.put('/:id', authenticate, requireRole('owner'), async (req, res) => {