优化考勤记录

backend/services/conduct_service.py

@@ -33,12 +33,18 @@ class ConductService:
         recorder_id: int,
         recorder_name: str
     ) -> Dict[str, Any]:
-        """
-        批量加减分
-        """
+        """批量加减分"""
+        # 输入校验
+        if not student_ids or len(student_ids) > 200:
+            return {"success": False, "message": "学生数量需在1-200之间"}
+        if not reason or not reason.strip() or len(reason) > 255:
+            return {"success": False, "message": "原因不能为空且不超过255字符"}
+        
         # 验证分值
         if points_change == 0:
             return {"success": False, "message": "分值不能为0"}
+        if abs(points_change) > 100:
+            return {"success": False, "message": "单次加减分不能超过100分"}
         
         # 获取操作人角色
         role = await PermissionChecker.get_user_role(recorder_id)
@@ -119,6 +125,9 @@ class ConductService:
     @staticmethod
     async def revoke_record(record_id: int, revoker_id: int) -> Dict[str, Any]:
         """撤销扣分记录"""
+        if not record_id or record_id <= 0:
+            return {"success": False, "message": "无效的记录ID"}
+        
         # 检查权限
         can_revoke = await PermissionChecker.check_can_revoke(revoker_id, record_id)
         if not can_revoke:
@@ -155,6 +164,9 @@ class ConductService:
     @staticmethod
     async def restore_record(record_id: int, restorer_id: int) -> Dict[str, Any]:
         """反撤销（恢复）已撤销的记录"""
+        if not record_id or record_id <= 0:
+            return {"success": False, "message": "无效的记录ID"}
+        
         # 检查权限：只有班主任可以反撤销
         role = await PermissionChecker.get_user_role(restorer_id)
         if role != "班主任":
@@ -207,6 +219,8 @@ class ConductService:
             end_date = None
         if related_type == "":
             related_type = None
+        if related_type and related_type not in ('manual', 'homework', 'attendance'):
+            return {"records": [], "page": page, "page_size": page_size, "total": 0, "total_pages": 0}
         
         role = await PermissionChecker.get_user_role(user_id)
         offset = (page - 1) * page_size